Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(temporary): removed caching from the build ci #284

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

anthonyronda
Copy link
Member

Unfortunately a fix I had implemented in October for build caching was seemingly never tested (it only ever rears its head in GitHub Actions).

The original fix --ignore-scripts still doesn't prevent husky from throwing an error when caching is enabled. We don't even use husky, it's a dependency for the type definitions.

We don't particularly need to cache our dependencies, it's just a best practice. I'd like to return to this when we're not late for a planned release

@anthonyronda anthonyronda requested a review from wyrmisis January 4, 2023 19:22
@anthonyronda anthonyronda merged commit 686ece6 into vttred:main Jan 4, 2023
@anthonyronda anthonyronda deleted the fix/remove-cache-again branch January 4, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant