Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a data model for Monster actors #275

Merged
merged 6 commits into from
Dec 30, 2022
Merged

feat: Add a data model for Monster actors #275

merged 6 commits into from
Dec 30, 2022

Conversation

wyrmisis
Copy link
Collaborator

Intent

This changeset adds a data model for the Monster actor type. it also scrubs some now-obsolete code from sheets and entities.

anthonyronda
anthonyronda requested changes Dec 29, 2022
View reviewed changes
Copy link
Member

@anthonyronda anthonyronda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With inventory enabled, monsters have a bugged encumbrance bar

image

So I think my only request for change is an "if character" handlebar block around the encumbrance bar in the inventory sheet template

anthonyronda
anthonyronda approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@anthonyronda anthonyronda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anthonyronda anthonyronda merged commit 5110cee into vttred:main Dec 30, 2022
@wyrmisis wyrmisis deleted the feat/monster-data-model branch January 18, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyronda anthonyronda anthonyronda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wyrmisis @anthonyronda