Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Attack/Initiative modifiers are visible on the sheet. #273

Merged
merged 1 commit into from
Dec 10, 2022
Merged

fix: Attack/Initiative modifiers are visible on the sheet. #273

merged 1 commit into from
Dec 10, 2022

Conversation

wyrmisis
Copy link
Collaborator

@wyrmisis wyrmisis commented Dec 9, 2022

Intent

This changeset fixes the disappearance of attack and initiative modifiers. It also gives us a lesson for using getters on the data models: we need to re-add them to the sheet context, since the way Foundry clones actor.system doesn't clone getters.

Fixes #271

@wyrmisis wyrmisis changed the title fix: Add actor.system getters to sheet context fix: Attack/Initiative modifiers are visible on the sheet. Dec 9, 2022
anthonyronda
anthonyronda approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@anthonyronda anthonyronda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anthonyronda anthonyronda merged commit 8c13827 into vttred:main Dec 10, 2022
@wyrmisis wyrmisis deleted the feat/271-attack-modifiers branch January 18, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyronda anthonyronda anthonyronda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Melee and Missile Modifiers missing from the sheet
2 participants
@wyrmisis @anthonyronda