SSHArc GA #5
Open
SSHArc GA #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgauth
reviewed
Apr 26, 2023
| if (exception.Body.Error.Code == "AuthorizationFailed") | ||
| { | ||
| //throw new AzPSApplicationException("You do not have authorization to create this endpoint. Only Contributor/Owner."); | ||
| throw new AzPSCloudException($"Client is not authrorized to create or update Service Configuration in the endpoint for {Name} in the Resource Group {ResourceGroupName}. This is an operation that must be performed by an account with Owner or Contributor role to allow SSH connections to the specified port {Port}. For more information see: https://aka.ms/ssharc/allow-ports."); |
There was a problem hiding this comment.
Suggested change
| throw new AzPSCloudException($"Client is not authrorized to create or update Service Configuration in the endpoint for {Name} in the Resource Group {ResourceGroupName}. This is an operation that must be performed by an account with Owner or Contributor role to allow SSH connections to the specified port {Port}. For more information see: https://aka.ms/ssharc/allow-ports."); | |
| throw new AzPSCloudException($"Client is not authorized to create or update Service Configuration in the endpoint for {Name} in the Resource Group {ResourceGroupName}. This is an operation that must be performed by an account with Owner or Contributor role to allow SSH connections to the specified port {Port}. For more information see: https://aka.ms/ssharc/allow-ports."); |
PaulHigin
suggested changes
Apr 26, 2023
| // attempt to create it if the user has permission | ||
| CreateServiceConfiguration(); | ||
| } | ||
| else if (exception.Body.Error.Code.Equals("ResourceNotFound")) |
There was a problem hiding this comment.
Do we know that these exception properties are always non-null? Should we use the pattern:
else if (exception.Body?.Error?.Code?.Equals("ResourceNotFound"))Also should the string compare be case insensitive?
src/Ssh/Ssh/Common/SshBaseCmdlet.cs
Outdated
| } | ||
|
|
||
| ValidateSshProxy(proxyPath); | ||
| //ValidateSshProxy(proxyPath); |
| if (result.Port != Int32.Parse(Port)) | ||
| { | ||
| return false; | ||
|
|
| private void CreateServiceConfiguration() | ||
| { | ||
| System.Collections.ObjectModel.Collection<ChoiceDescription> choices = new System.Collections.ObjectModel.Collection<ChoiceDescription> { new ChoiceDescription("N"), new ChoiceDescription("Y") }; | ||
| int userChoice = this.Host.UI.PromptForChoice($"The port {Port} that you are trying to connect to is not allowed for SSH connections for this resource. Would you like to update the current Service Confugration in the endpoint to allow connections to port {Port}?", "You must have owner or contributor roles in this resource to be able to change the service configuration. For more information see: http://aka.ms/ssharc/allow-ports", choices, 0); |
There was a problem hiding this comment.
This would be easier to read using parameter list names, and multiple lines:
int userChoice = Host.UI.PromptForChoice(
caption: $"The port...",
message: "You must have owner...",
choices: choices,
defaultChoices: 0);Also PowerShell coding guidelines recommends not using the this. keyword when referencing class properties or methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description