Az.Ssh Preview 2

[vthiebaut10]

Description

• Added automated scenario tests for export-azsshconfig
• Added -Rdp parameter
• Added support for private clouds ("Microsoft.ConnectedVMwarevSphere/virtualMachines", "Microsoft.ScVmm/virtualMachines","Microsoft.AzureStackHCI/virtualMachines")

Checklist

• Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

• SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
• SHOULD make the title of PR clear and informative, and in the present imperative tense.
• SHOULD update ChangeLog.md file(s) appropriately
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
  • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
• SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
  • Create new module from scratch
  • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
  • Create new resource type which name doesn't use module name as prefix
  • Have design question before implementation
• SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
• SHOULD have proper test coverage for changes in pull request.
• SHOULD NOT introduce breaking changes in Az minor release except preview version.
• SHOULD NOT adjust version of module manually in pull request

[PaulHigin]

Should there be a timeout for this connection wait? Can this wait be interrupted with Ctl+C?

[vthiebaut10]

Yes, it can be interrupted with a Ctrl+c, and in that case the function returns false and the cmdlet exits. I'm not totally sure if having a timeout is necessary since this function exits once the ssh process exits, and ssh has its own timeout. But I'll look into it and make sure.

[PaulHigin]

Is stderr still valid after the process exits? Can stderr.Readline() throw?

[vthiebaut10]

Yes, stderr is still valid once the process exits. You can still read any messages that were sent to stderr in between the last time you read stderr and the moment the process exits.

[vthiebaut10]

I don't think stderr.Readline() can throw as long as stderr is valid. I can add a check to make sure stderr is not null.

[PaulHigin]

I believe stderr is a StreamReader, in which case it can throw a IOException exception. Not sure if you want to catch it or let it propagate.