Remove trailing space from numericStepper when suffix doesn't exist #1218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
NumericStepper
has a weird behavior when there isn't a suffix. This contribution tries to fix it.I've parsed the suffix variable to check and see if there is any. In which case it puts whitespace between the number and the suffix, otherwise, it adds no space.
What problem is this solving?
You can check the behavior here https://www.als.com/edelws-cord-bulk-per-foot/p
Shoppers that want to put a high quantity in their carts are having trouble.
How should this be manually tested?
Just run
yarn styleguide
Types of changes