Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing space from numericStepper when suffix doesn't exist #1218

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

gris
Copy link
Contributor

@gris gris commented May 26, 2020

What is the purpose of this pull request?

NumericStepper has a weird behavior when there isn't a suffix. This contribution tries to fix it.

I've parsed the suffix variable to check and see if there is any. In which case it puts whitespace between the number and the suffix, otherwise, it adds no space.

What problem is this solving?

You can check the behavior here https://www.als.com/edelws-cord-bulk-per-foot/p

Shoppers that want to put a high quantity in their carts are having trouble.

How should this be manually tested?

Just run yarn styleguide

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@gris gris requested a review from a team May 26, 2020 18:05
@gris gris requested a review from a team as a code owner May 26, 2020 18:05
@gris gris requested a review from lucasecdb May 26, 2020 18:05
@vercel
Copy link

vercel bot commented May 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/styleguide-core/styleguide/n4o465v9u
✅ Preview: https://styleguide-git-fix-trailing-space-numeric-stepper.styleguide-core.now.sh

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4eef164:

Sandbox Source
wild-dawn-unzvm Configuration

@gris gris self-assigned this May 29, 2020
@gris gris added the 🐛 Bug label May 29, 2020
@emersonlaurentino emersonlaurentino merged commit 1c9b470 into master Jun 2, 2020
@emersonlaurentino emersonlaurentino deleted the fix/trailing-space-numeric-stepper branch June 2, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants