Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox prop "partial" isn't HTML compliant #1146

Closed
lucasecdb opened this issue Apr 3, 2020 · 2 comments · Fixed by #1169
Closed

Checkbox prop "partial" isn't HTML compliant #1146

lucasecdb opened this issue Apr 3, 2020 · 2 comments · Fixed by #1169
Assignees
Labels

Comments

@lucasecdb
Copy link
Contributor

Describe the bug
The prop partial in the Checkbox component doesn't respect HTML's specification.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Styleguide Checkbox's docs
  2. Inspect the "partial" checkbox and store the input element reference to use in the console.
  3. See the value of the property indeterminate of the input element.

Expected behavior

To have the indeterminate property of the input element set to true.

Screenshots

image

The temp0 variable is a reference to the second checkbox input's.

Additional context

Documentation.

@lucasecdb
Copy link
Contributor Author

can we also rename this prop to indeterminate? so it's more "aligned" with the HTML spec

@emersonlaurentino
Copy link
Member

@lucasecdb good catch, i will fix it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants