Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KR5 - Review Master Data API v1 #1034

Merged
merged 36 commits into from
Nov 21, 2023
Merged

KR5 - Review Master Data API v1 #1034

merged 36 commits into from
Nov 21, 2023

Conversation

julia-rabello
Copy link
Contributor

@julia-rabello julia-rabello commented Oct 31, 2023

I will add permissions in another pull request, still need to gather more information about the required resources for these endpoints.

Types of changes

  • New content (endpoints, descriptions or fields from scratch)
  • Improvement (make an endpoint's title or description even better)
  • Spelling and grammar accuracy (self-explanatory)

Changelog

Do not forget to update your changes to our Developer Portal's changelog. Did you create a release note?

  • Yes, I already created a release note about this change.
  • No, but I am going to.

@julia-rabello julia-rabello self-assigned this Oct 31, 2023
Copy link

Thanks for your contribution. The .json file will be checked now with Spectral.

@julia-rabello julia-rabello requested a review from a team November 1, 2023 21:24
@julia-rabello julia-rabello marked this pull request as ready for review November 1, 2023 21:24
Copy link
Contributor

@karenkrieger karenkrieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolver comentários e erros do spectral

VTEX - MasterData API - v10.2.json Outdated Show resolved Hide resolved
VTEX - MasterData API - v10.2.json Outdated Show resolved Hide resolved
VTEX - MasterData API - v10.2.json Outdated Show resolved Hide resolved
VTEX - MasterData API - v10.2.json Outdated Show resolved Hide resolved
VTEX - MasterData API - v10.2.json Outdated Show resolved Hide resolved
julia-rabello and others added 2 commits November 21, 2023 10:56
Co-authored-by: Karen Krieger <karen.krieger@vtex.com.br>
Copy link
Contributor

@karenkrieger karenkrieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julia-rabello julia-rabello merged commit c264b11 into master Nov 21, 2023
0 of 3 checks passed
@julia-rabello julia-rabello deleted the kr5-master-data-api-v1 branch November 21, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants