feat: Add vtexinternal as API environment (SFS-1667)
#2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lucasfp13
added
the
don't merge
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
lucasfp13
changed the title
vtexinternal as API environmentvtexinternal as API environment (SFS-1667)
lucasfp13
added
enhancement
lucasfp13
requested review from
emersonlaurentino,
renatamottam and
gvc
and removed request for
a team and
renatamottam
gvc
approved these changes
Oct 24, 2024
pedromtec
reviewed
Oct 24, 2024
pedromtec
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR intends to use the
vtexinternalinternal domain on calls to VTEX APIs.How it works?
Adding the new type (
vtexinternal) to theenvironmentAPI option, the@faststore/corewill receive this value through the global envHOMEBREW_API_ENVIRONMENTfrom stores served by Homebrew and build the BFF server using this value.Then, on
@faststore/apiwe will read thisenvironmentvalue and fetch the API calls using thevtexinternaldomain when it should.How to test it?
Check if all of the GraphQL requests are status 200.
The tests should be performed from the Starter deploy preview only, since locally we should not use this host (we validate that in the code).
Starters Deploy Preview
vtex-sites/starter.store#580
References
Check the
Opportunity: use vtexinternal on Homebrewinternal doc.