-
Notifications
You must be signed in to change notification settings - Fork 1
[SFS-1439] Implement custom sort for Unstructured #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c442160
to
073ac4d
Compare
b63bf06
to
ffe9017
Compare
ffe9017
to
cd4cc7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @biancasilvavtex !
I'm approving the PR but there is one last change I requested to use slices.Reverse
instead of implementing the reverse algorithm.
Co-authored-by: cezar-guimaraes <85624018+cezar-guimaraes@users.noreply.github.com>
82ef782
to
6c07acd
Compare
|
Description
Within this PR, we're extending the CEL functions to include a way to sort lists. The new
sort_by
function can be used in the following way:It supports all CEL types that implement the
Comparer
interface.Additionally, we also include the
Lists()
capabilities from K8s extensions. So now we can use something like this:What was done
custom_cel
specific for the code related to CELk8s.io/apiserver
a required dependency instead of indirectDocumentation