Skip to content

Conversation

@juliarocha
Copy link

@juliarocha juliarocha commented Jul 15, 2020

What did you change? *

Added integration with Doc Prop via markdown placeholder.

Why? *

Keeping the Store Components documentation up to date with the code and independent from manual documentation.

How to test it? *

Doc Prop working on some components:
https://juzon--appliancetheme.myvtex.com/docs/app/vtex.doc-prop-component@0.0.4/
https://juzon--appliancetheme.myvtex.com/docs/app/vtex.rich-text@0.10.4-beta/ (beta version - migration in PR)

Components without Doc Prop:
https://juzon--appliancetheme.myvtex.com/docs/app/vtex.flex-layout
https://juzon--appliancetheme.myvtex.com/docs/app/vtex.rich-text (current version)

Types of changes *

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical improvements

@juliarocha juliarocha requested review from gris, lucis and victorhmp July 15, 2020 17:58
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Jul 15, 2020

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

@juliarocha juliarocha marked this pull request as ready for review July 15, 2020 18:02
@gris
Copy link
Contributor

gris commented Jul 16, 2020

@juliarocha can you comment here some workspaces with your contributions. Examples with and without docprop, please?

Copy link
Collaborator

@victorhmp victorhmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, but please provide a way for us to test it :)

Also, please fix the linting issues pointed out by GitHub. A yarn lint --fix might be enough.

@gris
Copy link
Contributor

gris commented Jul 20, 2020

Looking good. I would only fix the minor lint issues and put // eslint-disable-next-line before the docprop trigger lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants