Skip to content

add a conditional field expression#6

Merged
wagnerlduarte merged 1 commit intomasterfrom
feature/BRPA-352-conditional-schema
Sep 23, 2021
Merged

add a conditional field expression#6
wagnerlduarte merged 1 commit intomasterfrom
feature/BRPA-352-conditional-schema

Conversation

@wagnerlduarte
Copy link
Collaborator

What problem is this solving?

Created a conditional to shows Expression field only when the Sort Strategy is selected with Custom Expression option.

How to test it?

Workspace

Screenshots or example usage:

conditional

How does this PR make you feel? 🔗

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Sep 22, 2021

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Sep 22, 2021

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@wagnerlduarte wagnerlduarte self-assigned this Sep 22, 2021
@github-actions
Copy link

github-actions bot commented Sep 22, 2021

Fails
🚫

We follow keepachangelog standards.

Please, change the file CHANGELOG.md adding a small summary of your changes under the [Unreleased] section. Example:

 ## [Unreleased]

+ ### Fixed
+ - Issue with image sizing in the SKU Selector.

Possible types of changes:

  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Generated by 🚫 dangerJS against d196679

Base automatically changed from feature/BRPA-352-sort-by-expression to master September 23, 2021 16:24
@wagnerlduarte wagnerlduarte merged commit 714d30d into master Sep 23, 2021
@vtex-io-docs-bot
Copy link

Beep boop 🤖 That's ok, I created an issue for this so we don't forget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants