Feature/brpa 352 sort by expression #5
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
|
react/utils/sortSellers.ts
Outdated
| ) | ||
|
|
||
| const parser = new Parser() | ||
| const expr = parser.parse(expression) |
There was a problem hiding this comment.
What does the parse function do if the expression is invalid? (very interesting solution btw; sorting sellers by a custom expression seems to be a very customizable/powerful approach 😄)
Oh, and by invalid, I mean a non-empty but incorrect expression.
There was a problem hiding this comment.
Good question! Apparently the application breaks with a invalid expression 😆😢
I will think about a solution for this problem 👨🦯
|
Beep boop 🤖 That's ok, I created an issue for this so we don't forget |
2 participants
What problem is this solving?
Added a new option to you make a math expression to sort sellers on Buybox Context. You can use this document to create expressions with seller variables.
Now it's possible use the productPrice and shippingPrice seller variables to create a expression to sort sellers.
We are working to add more variables in the next implementations. This is an initial implementation to test the solution.
How to test it?
Workspace
You can access Site Editor and create your expression like image bellow:
How does this PR make you feel? 🔗