Пряхин Степан ИСП-216В #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anst-foto
requested changes
Nov 14, 2022
index.html
Outdated
| </head> | ||
| <body class="menu"> | ||
| <div class="sidenav column"> | ||
| <h1 class="nh1">Company</h1> |
There was a problem hiding this comment.
имена классов должны соответствовать тому за что они отвечают.
index.html
Outdated
|
|
||
| <main> | ||
| <header class="header_style"> | ||
| <h1>Dashboard</h1> |
There was a problem hiding this comment.
h1 должен быть в единственном числе на всю страницу
| <header class="header_style"> | ||
| <h1>Dashboard</h1> | ||
| </header> | ||
| <article class="text_style"> |
There was a problem hiding this comment.
Suggested change
| <article class="text_style"> | |
| <div class="text_style"> |
index.html
Outdated
Comment on lines
135
to
141
| <p class="text"> | ||
| <label class="container"> | ||
| <input type="checkbox" checked="checked"> | ||
| <span class="checkmark"></span> | ||
| </label> | ||
| jgvyjvghj | ||
| </p> |
There was a problem hiding this comment.
Suggested change
| <p class="text"> | |
| <label class="container"> | |
| <input type="checkbox" checked="checked"> | |
| <span class="checkmark"></span> | |
| </label> | |
| jgvyjvghj | |
| </p> | |
| <input id="c1" type="checkbox" checked="checked"> | |
| <label for="c1" class="container"> | |
| jgvyjvghj | |
| </label> |
Comment on lines
+174
to
+185
| <table> | ||
| <tr> | ||
| <th>id</th> | ||
| <th>name</th> | ||
| <th>salary</th> | ||
| <th>country</th> | ||
| </tr> | ||
| <tr><td>1 </td><td>dacota rice </td><td>$36 </td><td>niger </td></tr> | ||
| <tr><td>2 </td><td>dacota rice </td><td>$36 </td><td>niger </td></tr> | ||
| <tr><td>3 </td><td>dacota rice </td><td>$36 </td><td>niger </td></tr> | ||
| <tr><td>4 </td><td>dacota rice </td><td>$36 </td><td>niger </td></tr> | ||
| </table> |
There was a problem hiding this comment.
Не хватает разделения на заголовок таблицы и её тело
style.css
Outdated
Comment on lines
16
to
26
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
|
обновил страницу |
|
Николенко @stark192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Николенко Сергей ИСП-216