Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for useFactory providers #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpmitche11
Copy link

@jpmitche11 jpmitche11 commented Aug 2, 2019

If you declare a provider with a useFactory function, sometimes it was being ignored and not registered in the angular module.

It looks like this was related to the deps property not handling the array style dependency inject annotation.
for example:

@NgModule({
  providers: [{ provide: 'SomeService', useFactory: [
    'service1', 'service2',
    function(service1, service2) { ... }
  ]}]
 })

The existing code expects useFactory to be a function, but it may be an array instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant