Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure #99

Closed
JooHyukKim opened this issue Dec 8, 2023 · 7 comments · Fixed by #100
Closed

Build failure #99

JooHyukKim opened this issue Dec 8, 2023 · 7 comments · Fixed by #100

Comments

@JooHyukKim
Copy link

Our ci is failing on docker build task. Anyone else having the same problem?

image

@vsoch
Copy link
Owner

vsoch commented Dec 8, 2023

Ah yeah I think I've seen this - with newer OS they get angry if you install to system python. Let me take a look.

@JooHyukKim
Copy link
Author

Ah yeah I think I've seen this - with newer OS they get angry if you install to system python. Let me take a look.

Thanksss!, idk if it's the host in Gihtub datacenter or the image registry

@vsoch
Copy link
Owner

vsoch commented Dec 8, 2023

@JooHyukKim here is the fix: #100

Since it builds from the Dockerfile, to test you should be able to target that branch, e.g., the action name @update-container-base. Let me know if it works! The build works locally for me, so we'd want to sanity check the virtual environment entrypoint is still good.

@vsoch
Copy link
Owner

vsoch commented Dec 8, 2023

Thanksss!, idk if it's the host in Gihtub datacenter or the image registry

It's likely the image in the docker registry "alpine" has a new latest with this change.

@JooHyukKim
Copy link
Author

JooHyukKim commented Dec 8, 2023

sick! Will let you know asap

@JooHyukKim
Copy link
Author

@vsoch works now! 👍🏼

@vsoch
Copy link
Owner

vsoch commented Dec 8, 2023

okay let's merge! All my actions that use this are in the process of throwing up on me too, lol. Thanks for the quick report!

@vsoch vsoch closed this as completed in #100 Dec 8, 2023
webknjaz added a commit to cherrypy/cheroot that referenced this issue Apr 1, 2024
This patch fixes a broken underlying container image.

Ref vsoch/pull-request-action#99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants