Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing missing default Kafka version #60

Merged
merged 1 commit into from
Dec 20, 2022
Merged

fixing missing default Kafka version #60

merged 1 commit into from
Dec 20, 2022

Conversation

wejdross
Copy link
Member

Checklist

  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • [x ] Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@wejdross wejdross added the bug Something isn't working label Dec 20, 2022
@wejdross wejdross requested a review from zugao December 20, 2022 10:54
@wejdross wejdross self-assigned this Dec 20, 2022
@wejdross
Copy link
Member Author

@zugao tested it locally, it's working :P

zugao
zugao approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wejdross
Copy link
Member Author

@glrf do You agree with the change? :)

@wejdross wejdross merged commit 162d53c into master Dec 20, 2022
@wejdross wejdross deleted the Kafka-fixes branch December 20, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugao zugao zugao approved these changes

@glrf glrf glrf approved these changes

Assignees

@wejdross wejdross

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wejdross @glrf @zugao