Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable mail configuration by default #534

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Enable mail configuration by default #534

merged 1 commit into from
Nov 13, 2024
+33 −21

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Nov 13, 2024 •
edited
Loading

The settings are adjusted to match APPUiO Cloud. According to internal docs our mailgun currently only supports the appuio.cloud domain.

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@Kidswiss
Enable mail configuration by default
f104f67 
The settings are adjusted to match APPUiO Cloud. According to internal
docs our mailgun currently only supports the `appuio.cloud` domain.
@Kidswiss Kidswiss added the patch label Nov 13, 2024
@Kidswiss Kidswiss requested review from a team, TheBigLee, wejdross and zugao and removed request for a team November 13, 2024 10:45
zugao
zugao approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The email is disabled as long as customer does not add his email, is that right?

@Kidswiss
Copy link
Contributor Author

LGTM. The email is disabled as long as customer does not add his email, is that right?

Yes that is correct.

Also, we might want to have another sender address in the future, but for now this is good enough... At least they should get mails with this.

@Kidswiss Kidswiss merged commit f462b43 into master Nov 13, 2024
28 checks passed
@Kidswiss Kidswiss deleted the fix/mail_settings branch November 13, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugao zugao zugao approved these changes

@TheBigLee TheBigLee Awaiting requested review from TheBigLee TheBigLee was automatically assigned from vshn/schedar

@wejdross wejdross Awaiting requested review from wejdross wejdross was automatically assigned from vshn/schedar

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kidswiss @zugao