Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ArgoCD ordering #533

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Introduce ArgoCD ordering #533

merged 1 commit into from
Nov 18, 2024

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Nov 12, 2024

With this commit, there are post process jobs that add ArgoCD annotations to various kinds.

It also adds wave annotations to the whole of the Crossplane helm, so that it's guaranteed to be applied first.

Additionally it introduces a new make target push-golden to use the forgejo and ArgoCD instances provider by kindev. Please consult the readme for further info.

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@Kidswiss Kidswiss added the minor label Nov 12, 2024
@Kidswiss Kidswiss requested review from a team, TheBigLee, wejdross and zugao and removed request for a team November 12, 2024 15:47
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
With this commit, there are post process jobs that add ArgoCD annotations
to various kinds.

It also adds wave annotations to the whole of the Crossplane helm, so
that it's guaranteed to be applied first.
@Kidswiss Kidswiss merged commit 176fd6c into master Nov 18, 2024
28 checks passed
@Kidswiss Kidswiss deleted the add/argocd branch November 18, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants