Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for appcat on fix/psql_encrypted_disk #493

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

vshnbot
Copy link
Collaborator

@vshnbot vshnbot commented Sep 26, 2024

Summary

There was a dependency loop that prevented the creation of VSHNPostgreSQL instances that use encrypted PVCs:

  • The SGCluster object can't be created before the luks secret for the PVC is generated
  • The luks secret can't be created without getting the instance count of the cluster object

This has been resolved by relying on the instance count from the composite and also waiting for the luks secrets to be present before attempting to access the sgcluster object to be able to override the storageClass for the PVCs

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

Link: vshn/appcat#236

@TheBigLee TheBigLee added bug Something isn't working patch labels Sep 27, 2024
@TheBigLee TheBigLee merged commit ca813ad into master Sep 27, 2024
27 checks passed
@TheBigLee TheBigLee deleted the appcat/236/fix/psql_encrypted_disk branch September 27, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants