Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dbaas cronjob #29

Merged
merged 1 commit into from
Dec 9, 2022
Merged

add dbaas cronjob #29

merged 1 commit into from
Dec 9, 2022

Conversation

mweibel
Copy link
Contributor

@mweibel mweibel commented Dec 7, 2022

Summary

add missing DBaaS cronjob to component.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@mweibel mweibel added the enhancement New feature or request label Dec 7, 2022
@mweibel mweibel requested review from glrf and zugao December 7, 2022 14:21
glrf
glrf reviewed Dec 7, 2022
View reviewed changes
Copy link
Contributor

@glrf glrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only thing before I can approve this is that you add the new parameters to the reference in the doc

component/class/defaults.yml Outdated Show resolved Hide resolved
component/class/defaults.yml Outdated Show resolved Hide resolved
component/component/main.jsonnet Outdated Show resolved Hide resolved
@mweibel mweibel force-pushed the add-dbaas-cronjob branch 2 times, most recently from 16c1656 to 6ab71f7 Compare December 9, 2022 12:16
@mweibel
Copy link
Contributor Author

mweibel commented Dec 9, 2022

nice catch about the docs - didn't verify those and they're updated now.

@mweibel mweibel requested a review from glrf December 9, 2022 12:21
glrf
glrf approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@glrf glrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mweibel mweibel merged commit 0bff9a6 into master Dec 9, 2022
@mweibel mweibel deleted the add-dbaas-cronjob branch December 9, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glrf glrf glrf approved these changes

@zugao zugao Awaiting requested review from zugao

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mweibel @glrf