Skip to content

Trigger release in pre-release workflow #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zugao merged 1 commit into from
Aug 13, 2025
Merged

Trigger release in pre-release workflow #448

zugao merged 1 commit into from
Aug 13, 2025
+24 −12

Conversation

@zugao
Copy link
Collaborator

@zugao zugao commented Aug 13, 2025 •
edited
Loading

Summary

  • GITHUB_ACTION token cannot trigger the Release workflow due to security reasons. We need another step to explicetly trigger a release otherwise during scheduled release only a tag will be created. This PR addressed this issue.

Checklist

  • Update tests.
  • Link this PR to related issues.
  • Merge with /merge comment.

Component PR: vshn/component-appcat#874

@zugao zugao force-pushed the fix-automatic-prerelease branch from b1f84ae to ab388cd Compare August 13, 2025 08:44
@zugao zugao requested review from a team, Kidswiss, TheBigLee and ThisIsntTheWay and removed request for a team August 13, 2025 08:44
@vshnbot vshnbot mentioned this pull request Aug 13, 2025
Open
3 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2025

@zugao zugao added the minor label Aug 13, 2025
@mdnix mdnix self-requested a review August 13, 2025 09:21
mdnix
mdnix approved these changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@mdnix mdnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zugao zugao merged commit 4e90882 into develop Aug 13, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheBigLee TheBigLee TheBigLee approved these changes

@mdnix mdnix mdnix approved these changes

@Kidswiss Kidswiss Awaiting requested review from Kidswiss Kidswiss was automatically assigned from vshn/schedar

@ThisIsntTheWay ThisIsntTheWay Awaiting requested review from ThisIsntTheWay ThisIsntTheWay was automatically assigned from vshn/schedar

Assignees

No one assigned

Labels

minor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zugao @TheBigLee @mdnix