Re-write alerts so they work with cluster monitoring #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kidswiss
requested review from
a team,
TheBigLee,
wejdross and
zugao
and removed request for
a team
The current user-workload alerts will not properly work with the cluster workload monitoring, because: * A specific `"syn": "true"` label is missing * They don't filter for the namespace. So each alert would trigger for each instance that is running. The second part needed a bit more involved refactoring, as we have to pass the specific namespace for each instance and can't just match in a generic manner.
Kidswiss
force-pushed
the
fix/non-sla-namespace
branch
from
fc5e95e
to
4380175
Compare
3 tasks
zugao
approved these changes
Nov 15, 2024
| @@ -5,7 +5,7 @@ import ( | |||
| "k8s.io/apimachinery/pkg/util/intstr" | |||
| ) | |||
|
|
|||
| // ServiceRule is a func definition to get a specific rule based on a container name s | |||
| // ServiceRule is a func definition to get a specific rule based on a container name s and namespace name n | |||
There was a problem hiding this comment.
Suggested change
| // ServiceRule is a func definition to get a specific rule based on a container name s and namespace name n | |
| // ServiceRule is a func definition to get a specific rule based on a container name s and namespace name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current user-workload alerts will not properly work with the cluster workload monitoring, because:
"syn": "true"label is missingThe second part needed a bit more involved refactoring, as we have to pass the specific namespace for each instance and can't just match in a generic manner.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog