Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'TSLint' instead of 'ESLint'. #777

Merged
merged 1 commit into from
Feb 27, 2017

Conversation

JimiC
Copy link
Member

@JimiC JimiC commented Feb 27, 2017

No description provided.

@JimiC
Copy link
Member Author

JimiC commented Feb 27, 2017

Not sure where this file is used though.

@jens1o
Copy link
Member

jens1o commented Feb 27, 2017

In fact, is was planned in the early stages with the extension. It was my idea. But I think it's obsolete.

@JimiC
Copy link
Member Author

JimiC commented Feb 27, 2017

That's what I thought. @robertohuertasm Does this go to the Trash Bin?

@robertohuertasm
Copy link
Member

This is from when we used vanilla js. It has no sense now.

@robertohuertasm robertohuertasm merged commit 65d1f5d into vscode-icons:master Feb 27, 2017
@JimiC JimiC deleted the contributing_fix branch February 27, 2017 16:36
@jens1o
Copy link
Member

jens1o commented Feb 27, 2017

Why did you merged this? Shouldn't it removed? 😄

@JimiC
Copy link
Member Author

JimiC commented Feb 27, 2017

Apparently, it has sentimental value to @robertohuertasm 🤣

@robertohuertasm
Copy link
Member

Do you want to remove the file? I thought you were talking about the Eslint reference.

@jens1o
Copy link
Member

jens1o commented Feb 27, 2017

nah, we want to remove the line. 😆

@JimiC
Copy link
Member Author

JimiC commented Feb 27, 2017

Why not remove the file entirely?

@jens1o
Copy link
Member

jens1o commented Feb 27, 2017

Because maybe someone does not know the common conventions when creating PRs?

@robertohuertasm
Copy link
Member

This document is the one everyone creating an issue or a PR has access to via a link:
image

Why do you want to remove it?

@JimiC
Copy link
Member Author

JimiC commented Feb 27, 2017

PRs have their own md.

@JimiC
Copy link
Member Author

JimiC commented Feb 27, 2017

So that where it's used, finally. So either we keep the line with reference to TSLint or we remove the line as linting is embedded in the CI.

@jens1o
Copy link
Member

jens1o commented Feb 27, 2017

Hmm, I would let it there. So the PR is just fine.

@robertohuertasm
Copy link
Member

I'll keep the reference so they are advised to test it locally before arriving to CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants