Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Webpack #310

Merged
merged 3 commits into from
Sep 15, 2016
Merged

add Webpack #310

merged 3 commits into from
Sep 15, 2016

Conversation

jens1o
Copy link
Member

@jens1o jens1o commented Sep 14, 2016

_Fixes #305_

Changes proposed:

  • Add
  • Prepare
  • Delete
  • Fix

Things I've done:

  • I've pulled the latest master branch
  • I've run npm install to install all the dependenies
  • I've checked my code, it is clean.
  • I've run ESLint.
  • My pull request fixes an issue, I referenced the issue.
  • My pull request is not too big, otherwise I've already squashed it.
  • I've run npm run build to build the extension. (If I had done something with the extension.)

adds webpack.

@robertohuertasm Is it right like this?

@robertohuertasm
Copy link
Member

@jens1o it's ok! Sorry for the delay in my answer. I'm a little busy these days... 😞

@robertohuertasm robertohuertasm merged commit df3feb0 into vscode-icons:master Sep 15, 2016
@robertohuertasm robertohuertasm mentioned this pull request Sep 15, 2016
@jens1o
Copy link
Member Author

jens1o commented Sep 15, 2016

Don't worry 😃

@snowgrus
Copy link

webpack.config.dev.js or webpack.config.*.js not support

@jens1o
Copy link
Member Author

jens1o commented Sep 18, 2016

@wgruis Look here: #313 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants