Elaborate on link tag id prop for vscode-icon #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was banging my head against the wall for a couple of hours yesterday as I couldn't make icons to show up in my extension. My initial thought was an error in the way assets are bundled and resolved or some misconfigured CSPs but it was much simpler. Had i just copied the line from the icon documentation it probably would have worked out of the box.
Long story short, I was missing the
idon the link tag. So after reading the implementation I understood what it's used for and why it's needed. I also found that there were at least 2 occurrences of the same issue (vscode-elements/elements#15 and vscode-elements/elements#125).Let me know if you think stating the necessity a bit more explicitly and elaborating in the docs makes sense (it certainly would have helped me not overlooking this).
I'm also open for addressing this in a different way (like an
Infoboxor similar).