Skip to content

Split change tests #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bendera merged 2 commits into from
Feb 24, 2025
Merged

Split change tests #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86cec2d
Finish test
bendera Feb 24, 2025
8c17573
Update changelog
bendera Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
## Fixed

- **Button**: Fixed the button border style.
- **SplitLayout**: Prevented the handle position from resetting when the `split` property is changed
to the same value as before.

### Added

Expand Down
9 changes: 6 additions & 3 deletions src/vscode-split-layout/vscode-split-layout.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,7 @@ describe('vscode-split-layout', () => {
});
});

it.only('should not reset handle position when split is set to the same value', async () => {
it('should not reset handle position when split is set to the same value', async () => {
const el = await fixture<VscodeSplitLayout>(
html`<vscode-split-layout
style="width: 500px; height: 500px;"
Expand All @@ -667,12 +667,15 @@ describe('vscode-split-layout', () => {
await el.updateComplete;

const handle = el.shadowRoot!.querySelector('.handle') as HTMLDivElement;
expect(handle.offsetTop).to.eq(198);
await dragElement(handle, 0, 50);

const handleYPosBefore = handle.offsetTop;

el.setAttribute('split', 'horizontal');
await el.updateComplete;

expect(handle.offsetTop).to.eq(198);
expect(handleYPosBefore).to.eq(248);
expect(handle.offsetTop).to.eq(248);
});

// TODO
Expand Down
Loading