Skip to content

Fix missing fields in EquitySummaryByReportDateInBase#6

Merged
vroonhof merged 1 commit intomasterfrom
fix-issue-132-missing-fields-9228664759381441106
Feb 5, 2026
Merged

Fix missing fields in EquitySummaryByReportDateInBase#6
vroonhof merged 1 commit intomasterfrom
fix-issue-132-missing-fields-9228664759381441106

Conversation

@vroonhof
Copy link
Owner

@vroonhof vroonhof commented Feb 5, 2026

Fix parsing error for EquitySummaryByReportDateInBase by adding missing fields:

  • liteSurchargeAccrualsLong
  • liteSurchargeAccrualsShort
  • cgtWithholdingAccruals
  • cgtWithholdingAccrualsLong
  • cgtWithholdingAccrualsShort

Also included a regression test with the XML example provided in the issue.


PR created automatically by Jules for task 9228664759381441106 started by @vroonhof

Added `liteSurchargeAccrualsLong`, `liteSurchargeAccrualsShort`, `cgtWithholdingAccruals`, `cgtWithholdingAccrualsLong`, and `cgtWithholdingAccrualsShort` to `EquitySummaryByReportDateInBase` dataclass in `ibflex/Types.py` to fix parsing errors reported in issue #132.
Added a regression test `tests/test_equity_summary_fields.py` to verify the fix.

Co-authored-by: vroonhof <38109466+vroonhof@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant