Skip to content

Mark package as vendored with version suffix and documentation#5

Merged
vroonhof merged 3 commits intomasterfrom
copilot/vendor-package-version-update
Feb 5, 2026
Merged

Mark package as vendored with version suffix and documentation#5
vroonhof merged 3 commits intomasterfrom
copilot/vendor-package-version-update

Conversation

Copy link

Copilot AI commented Feb 5, 2026

This repository is a vendored fork with additional fields beyond the upstream. Need to make the vendoring explicit in package metadata and documentation.

Changes

Version metadata (ibflex/__version__.py):

  • Version: 0.160.16+vroonhof.vendored (PEP 440 local version identifier)
  • Repository URL: updated to vroonhof/ibflex

Documentation (README.rst):

  • Added vendoring notice at top explaining:
    • Fork relationship to original csingley/ibflex
    • Additional data fields included
    • Incorporation of robcohen/ibflex2 improvements
    • Version suffix convention

Package metadata now correctly identifies this as a vendored variant:

>>> import ibflex
>>> ibflex.__version__
'0.16+vroonhof.vendored'
>>> ibflex.__url__
'https://github.com/vroonhof/ibflex'
Original prompt

We are vendoring this more and more.

  • in whatever is pythonic standard set the version of this package so that is obvious we vendored it
  • add a blurb to the readme, saying that this a vendored copy with more fields added and that it includes changes from robcohen/ibflex2

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: vroonhof <38109466+vroonhof@users.noreply.github.com>
Copilot AI changed the title [WIP] Vendor package with versioning and README update Mark package as vendored with version suffix and documentation Feb 5, 2026
Copilot AI requested a review from vroonhof February 5, 2026 21:46
Copy link
Owner

@vroonhof vroonhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a mention of the functionality in the readme. that was just merged that allows it to be tolerant against new (unknown) attributes.

@vroonhof vroonhof marked this pull request as ready for review February 5, 2026 22:12
Copy link
Author

Copilot AI commented Feb 5, 2026

add a mention of the functionality in the readme. that was just merged that allows it to be tolerant against new (unknown) attributes.

I checked the codebase but couldn't find the tolerance feature you mentioned. The current parser.py (line 119-121) raises a FlexParserError when encountering unknown attributes.

Could you clarify:

  1. Was this feature in PR Fix initialInvestment type and add liteSurchargeAccruals field #2, or a different PR?
  2. Should I implement the tolerance feature now and then document it, or is it already present somewhere I'm missing?

Copilot AI requested a review from vroonhof February 5, 2026 22:15
Updated README to clarify enhancements and features of the vendored ibflex library.
@vroonhof vroonhof merged commit 3992906 into master Feb 5, 2026
@vroonhof vroonhof deleted the copilot/vendor-package-version-update branch February 5, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants