Handle SubAssetKey instead of string strictly #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santarh
changed the title
ousttrue
reviewed
May 25, 2021
| UnityPath m_textureDirectory; | ||
|
|
||
| public TextureExtractor(GltfParser parser, UnityPath textureDirectory, (SubAssetKey, UnityEngine.Texture2D)[] subAssets) | ||
| public TextureExtractor(GltfParser parser, UnityPath textureDirectory, IReadOnlyDictionary<SubAssetKey, Texture> subAssets) |
There was a problem hiding this comment.
(SubAssetKey, UnityEngine.Texture2D)[] => IReadOnlyDictionary<SubAssetKey, Texture>
ousttrue
reviewed
May 25, 2021
| public class TextureFactory : IDisposable | ||
| { | ||
| public readonly Dictionary<string, Texture2D> ExternalMap; | ||
| private readonly Dictionary<SubAssetKey, Texture> m_temporaryTextures = new Dictionary<SubAssetKey, Texture>(); |
ousttrue
reviewed
May 25, 2021
| /// </summary> | ||
| public bool ExtractConverted => TextureType == TextureImportTypes.StandardMap; | ||
| public SubAssetKey SubAssetKey => new SubAssetKey(SubAssetKey.TextureType, UnityObjectName); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectや SubAsset のObjectに対する取り回しがstringで曖昧なのをSubAssetKeyで厳密に取り扱うSubAssetKeyを不用意に外部でnewしないようにするSubAssetKeyをTexture2DではなくTextureで取り扱うTextureImportParamは「Import した結果生成される Texture Asset 1 つ」に対応する。TextureFactoryには残さず、処理中に破棄する.gltf形式のインポート時も、Texture は SubAsset となる