Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VRM1] SpringBone center をモデルレベルに移動など #880

Merged
merged 4 commits into from
Apr 16, 2021
Merged

[VRM1] SpringBone center をモデルレベルに移動など #880

merged 4 commits into from
Apr 16, 2021

Conversation

ousttrue
Copy link
Contributor

スプリングボーン周り

  • Spring と Collider をヒエラルキーから探索するのが大変なので、 VRM10SpringSelectorWindow 作った。
  • 構成変更により無効になった Gizmo を復旧
  • SpringBone の center の仕様を変更

ousttrue added 4 commits April 16, 2021 16:29
@ousttrue
VRM10SpringSelectorWindow
83c407a
@ousttrue
OnDrawGizmosSelected
fc5e767
@ousttrue
auto reload
a03f423
@ousttrue
VRM10SpringBone.m_center を VRM10Controller.SpringBoneCenter に移動 (Spri…
cff9dfa 
…ngごとではなくModel全体の設定に)

springの設定ではなくて、springが動く環境の設定。アプリが任意に設定する想定。
@ousttrue ousttrue requested a review from Santarh April 16, 2021 08:15
Santarh
Santarh approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@Santarh Santarh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

手元で試したところ、Gizmo いい感じで動いてます！

しかしそれで判明したこと：実はマイグレーション時に、コライダ位置の X 軸の値が反転している

@ousttrue
Copy link
Contributor Author

migration のバグ次でなおします。

@ousttrue ousttrue merged commit ecd9568 into vrm-c:master Apr 16, 2021
@ousttrue ousttrue mentioned this pull request Apr 16, 2021
Merged
@ousttrue ousttrue deleted the feature10/impl_springbone branch May 17, 2021 05:22
@ousttrue ousttrue added the 1.0 label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Santarh Santarh Santarh approved these changes

Assignees
No one assigned
Labels
1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ousttrue @Santarh