Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VRM10SpringBone を MonoBehaviour にした #877

Merged

Conversation

ousttrue
Copy link
Contributor

SpringBone単位に Edit する。
個別に MonoBehaviour になったので、VRM10Controller でまとめて CustomEditor するのをやめた。

@ousttrue ousttrue requested a review from Santarh April 15, 2021 10:46
@ousttrue ousttrue changed the title VRM10SpringBone を SpringBone にした VRM10SpringBone を MonoBehaviour にした Apr 15, 2021
@Santarh
Copy link
Contributor

Santarh commented Apr 15, 2021

前提知識:
VRM 0.x の SpringBone は、SpringBone にしたい Root GameObject を指定するだけの設計だった。

VRM 1.0 の SpringBone は、SpringBone の中の Joint ごとに設定を可変にできるようになるため
各所に MonoBehaviour を挿すという構造設計にする。

具体的には

  • SpringBone の根元 VRM10SpringBone
  • SpringBone の関節 VRM10SpringJoint
  • SpringBone と衝突するコライダ集合 VRM10SpringBoneColliderGroup

Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう

/// </summary>
[DisallowMultipleComponent]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpringBone は 1 GameObject に 1 本なので OK

@@ -7,7 +7,6 @@ namespace UniVRM10
/// <summary>
/// VRMC_node_collider
/// </summary>
[DisallowMultipleComponent]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ColliderGroup は SpringBone に当たる方の定義なので重複して OK

@ousttrue ousttrue merged commit 45d31ab into vrm-c:master Apr 15, 2021
@ousttrue ousttrue deleted the feature10/VRM10SpringBone_is_monobehaviour branch May 17, 2021 05:22
@ousttrue ousttrue added the 1.0 label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants