Skip to content

SpringBoneSystem cannot handle joints with same transform #2617

Closed
@TigerHix

Description

@TigerHix

for (int i = 0; i < m_joints.Count; ++i)
{
m_jointIndexMap.Add(m_joints[i].Item1, i);
}

Instead of Add, just use m_jointIndexMap[m_joints[i].Item1] = i here. Otherwise this breaks compatibility with a ton of VRM 0.x models that have joints with the same transform.

Side question: this change was made 5 months ago. Are there any back compatibility tests or regression tests in-place for UniVRM? VRM is now a huge ecosystem, and constantly making changes that break older models is very concerning for the most popular VRM runtime.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions