Skip to content

Conversation

@VinyarionHyarmendacil
Copy link
Contributor

@VinyarionHyarmendacil VinyarionHyarmendacil commented Dec 4, 2025

Addresses #202, #480, #489 (#536 is duplicate), #495, #497, #498
Better document and type-limit properties for CalendarEvent
Add GET /calendar/{groupId}/next
Add GET /inventory/collections
Fix GET /user/{userId}/inventory/{inventoryItemId} having incorrect path and being absent from paths.yaml
Moderation Reports:
Add GET /moderationReports
Add POST /moderationReports
Add DELETE /moderationReports/<modReportId>
Notification V2:
Add GET /notifications
Add DELETE /notifications
Add GET /notifications/{notificationId}
Add DELETE /notifications/{notificationId}
Add POST /notifications/{notificationId}/reply
Add POST /notifications/{notificationId}/respond
Add POST /notifications/{notificationId}/see

Addresses vrchatapi#202, vrchatapi#480, vrchatapi#489, vrchatapi#495, vrchatapi#497, and vrchatapi#498
Merge TwoFactorAuthCode and TwoFactorEmailCode schemas into TwoFactorCode
Better document and type-limit properties for CalendarEvent
Add `GET /calendar/{groupId}/next`
Add `GET /inventory/collections`
Fix `GET /user/{userId}/inventory/{inventoryItemId}` having incorrect path and being absent from paths.yaml
Moderation Reports:
Add `GET /moderationReports`
Add `POST /moderationReports`
Add `DELETE /moderationReports/<modReportId>`
Notification V2:
Add `GET /notifications`
Add `DELETE /notifications`
Add `GET /notifications/{notificationId}`
Add `DELETE /notifications/{notificationId}`
Add `POST /notifications/{notificationId}/reply`
Add `POST /notifications/{notificationId}/respond`
Add `POST /notifications/{notificationId}/see`
@VinyarionHyarmendacil
Copy link
Contributor Author

lint go brrrrr

@ariesclark
Copy link
Member

fixed ci, I recommend you run pnpm lint-eslint --fix and review the changes.

…UserRequest.hasSharedConnectionsOptOut for opting out of Mutuals feature
i swear if it misses something one more time
@VinyarionHyarmendacil VinyarionHyarmendacil mentioned this pull request Dec 5, 2025
@jellejurre
Copy link
Contributor

when calling getnotificationv2 I get
Unhandled exception. VRChat.API.Client.ApiException: Error calling GetNotificationV2: {"error":{"message":""Invalid Admin Credentials"","status_code":403}}

@jellejurre
Copy link
Contributor

apart from this, LGTM

@VinyarionHyarmendacil
Copy link
Contributor Author

when calling getnotificationv2 I get Unhandled exception. VRChat.API.Client.ApiException: Error calling GetNotificationV2: {"error":{"message":""Invalid Admin Credentials"","status_code":403}}

I also got this, I presume this is intended behavior as normal users get notifications pushed via pipeline or query them via GET /notifications itself: there isn't really a reason for normal users (moderation probably has perms for investigative purposes ofc) to fetch individual notifications, but as a NotificationV2 is the only type that makes any sense to be returned on success, that's what I put. At the rate that notifications actually get created, it would probably make permitting this a huge potential resource sink.

@ariesclark
Copy link
Member

Could add x-admin: true on the operation, then we could bundle it out & create separate admin bundles? Not sure how useful they'd be though.

@VinyarionHyarmendacil
Copy link
Contributor Author

Eh, should I mark as deprecated and add (in more professional language) "needs admin creds by default, expect 403" to the description?

@jellejurre jellejurre merged commit 001b64f into vrchatapi:main Dec 9, 2025
6 checks passed
@VinyarionHyarmendacil VinyarionHyarmendacil deleted the miscellaneous-5 branch December 9, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants