Skip to content

error out if value to write is non-string #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

error out if value to write is non-string #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c190f0
error out if value to write is non-string
neilk-vrchat May 27, 2021
49ea91e
bump version
neilk-vrchat May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/Tance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,16 @@ class Tance{
//console.info("cache MISS: ", searchId);
let returnVal = await fn.apply(fn, args);
let serializedReturnVal = serializationFn(returnVal);
if (typeof serializedReturnVal !== 'string') {
console.error(
`REDIS-TANCE: about to write a non-string, giving up. ` +
`Cache args: ${fn}, ${fnName}, ${serializationFn}, ${deserializationFn}, ${ignoreArgs} ` +
`Function args: ${JSON.stringify(args)}, ` +
`returnVal: ${JSON.stringify(returnVal)} ` +
`serializedReturnVal: ${typeof serializedReturnVal} ` + JSON.stringify(serializedReturnVal)
);
return returnVal;
}
await this.set(`${fnName}_${searchIdHash}`, serializedReturnVal, 'EX', durationInSeconds);
await this._indexItemOnEntry(args, fnName, `${fnName}_${searchIdHash}`, durationInSeconds);
await this.sadd(`${fnName}_keys`, `${fnName}_${searchIdHash}`);
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "redistance",
"version": "1.10.0",
"version": "1.10.1",
"description": "a collection of useful redis utilities",
"main": "index.js",
"dependencies": {
Expand Down