-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Adding custom envelope key option for server and client header fix (take 2 for 1208 and 1170) #1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smokhov
wants to merge
12
commits into
vpulim:master
Choose a base branch
from
smokhov:soapenv-header-fix-1208-1170
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #1208 (by @gamzeoguz) by making sure the tests pass, adding 2 new tests and covering Faults. The original PR's 2 tests were not passing because actually they were Faults in response as empty Body is not allowed at the server by default here:
node-soap/src/server.ts
Line 322 in 9452702
envelopeKey
set tosoapenv
. To cover happy-case scenarios I've added two more tests with some actual Body and expected response from other tests, with and withoutenvelopeKey
set tosoapenv
at for the client with some request data. So this covers #1208.For #1170 (by @amalashenok) at first I though it was also relevant as the line was around the
envelopeKey
handling for the client, but it turns out it was not the case, so I wrote a brand new test for it after reproduction. Please check.