Skip to content

Conversation

githubgehrmann
Copy link

Pull Request (PR) description

We'd like to use this Puppet module to deploy our Zabbix infrastructure but to fully configer it for our needs there are missing some parameters. Im not able to fully test my additions, so a code review and/or testing is recommended.

Following parameters where added
  • Server:
    • StartHistoryPollers
    • TrendFunctionCacheSize
  • Agent:
    • StatusPort
    • PersistentBufferPeriod
    • ControlSocket

This Pull Request (PR) fixes the following issues

n.a.

@Valantin
Copy link
Contributor

Valantin commented Oct 2, 2024

Hi, can you add the Type to parameter added in this PR?
Can you squash the commits?

@githubgehrmann githubgehrmann force-pushed the add-configuration-parameters-to-server-and-agent branch 2 times, most recently from f4f8610 to a05e0cd Compare October 7, 2024 10:33
@bastelfreak bastelfreak added the enhancement New feature or request label Oct 7, 2024
@githubgehrmann githubgehrmann force-pushed the add-configuration-parameters-to-server-and-agent branch 2 times, most recently from 2899ecb to 8b86dea Compare October 7, 2024 12:58
@githubgehrmann
Copy link
Author

All added parameters have a type specified.
The commits are squashed.

@githubgehrmann
Copy link
Author

Hello,
is there something missing for this request to be pulled?
I'd like to add the code befor other changes force me to rework it.
kind regards

@githubgehrmann
Copy link
Author

Hello,
is there someone i can ask for to review this cool. It seams fine to me.
But i can't add any reviewers or assignees.
kind regards

@githubgehrmann githubgehrmann force-pushed the add-configuration-parameters-to-server-and-agent branch 2 times, most recently from 8b2c580 to ba8c193 Compare May 12, 2025 12:11
@githubgehrmann githubgehrmann requested a review from Valantin May 12, 2025 12:37
@githubgehrmann githubgehrmann force-pushed the add-configuration-parameters-to-server-and-agent branch from ba8c193 to 72ce78e Compare May 12, 2025 13:47
@githubgehrmann githubgehrmann changed the title Add configuration parameters to server and agent Add configuration parameters to server, proxy and agent May 13, 2025
@Valantin
Copy link
Contributor

Can you fix the failed check?

@githubgehrmann
Copy link
Author

Trying to. I do not have the plattform for local testing and am not that familiar with puppet errors.
Thanks for the quick responce anyway :)

@githubgehrmann githubgehrmann force-pushed the add-configuration-parameters-to-server-and-agent branch 2 times, most recently from db41b0a to 8ede922 Compare May 15, 2025 12:38
@githubgehrmann githubgehrmann force-pushed the add-configuration-parameters-to-server-and-agent branch 10 times, most recently from 8774123 to db4f043 Compare May 19, 2025 12:07
@githubgehrmann githubgehrmann force-pushed the add-configuration-parameters-to-server-and-agent branch from db4f043 to 0c2853d Compare May 19, 2025 12:43
@githubgehrmann githubgehrmann force-pushed the add-configuration-parameters-to-server-and-agent branch 3 times, most recently from 0825093 to 7b01b70 Compare May 20, 2025 07:10
@githubgehrmann
Copy link
Author

githubgehrmann commented May 20, 2025

Can you fix the failed check?

All other checks fail, in no context to this code

@githubgehrmann githubgehrmann force-pushed the add-configuration-parameters-to-server-and-agent branch 3 times, most recently from 4375014 to 34be9e4 Compare May 28, 2025 11:33
@githubgehrmann githubgehrmann force-pushed the add-configuration-parameters-to-server-and-agent branch 2 times, most recently from c4ab83d to 9c1f6bb Compare June 12, 2025 07:56
@githubgehrmann githubgehrmann force-pushed the add-configuration-parameters-to-server-and-agent branch from 9c1f6bb to d79ff41 Compare June 24, 2025 06:27
 - Server:
    - making StartHistoryPollers configurable
    - adding TrendFunctionCacheSize parameter to config file

 - Agent:
    - adding StatusPort parameter to config file
    - adding PersistentBufferPeriod parameter to config file
    - adding ControlSocket parameter to config file

 - Proxy
    - making ProxyBufferMode configurable
    - making ProxyMemoryBufferSize configurable
    - making ProxyMemoryBufferAge configurable

return parameters to a desired state
@githubgehrmann githubgehrmann force-pushed the add-configuration-parameters-to-server-and-agent branch from d79ff41 to 68cba90 Compare July 8, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants