Add support for purging unmanaged config fragments #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yankcrime
reviewed
Jan 16, 2017
| group => 'telegraf', | ||
| notify => Class['::telegraf::service'], | ||
| require => Class['::telegraf::install'], | ||
| file { |
There was a problem hiding this comment.
Nice, I was wondering when some Puppet 4 syntax would finally creep in ;)
This is great, but you'll need to update the module's metadata to state this as a requirement. I'll then call it out as a breaking change in version 2.0.
There was a problem hiding this comment.
Ah sorry, I didn't even think about that when I was writing it. I'm happy to modify it so that it'll work on older Puppets.
There was a problem hiding this comment.
Yes, probably a good idea to maintain compatibility with older versions of Puppet for now.
There was a problem hiding this comment.
Updated. I've repeated the parameters on each file than using File {} to avoid scope-related weirdness, however unlikely.
added 2 commits
January 19, 2017 10:22
This currently defaults to disabled to ease migration from previous versions.
This doesn't rely on File {} defaults to avoid potential scope
weirdness, however unlikely.
yankcrime
approved these changes
Jan 18, 2017
|
Thanks @cosmopetrich ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @joshuaspence in #39.
This defaults to disabled to ease migration from previous versions.
I've taken a slightly different approach to #2, in that I've decoupled the parameter names from 'inputs' since conf.d directory could foreseeably be used for outputs and filters. I'm more than happy to change the names etc if you'd prefer different ones.
Please let me know your thoughts, and thanks for all your work on this module!