Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DNSoverTLS #88

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

shibumi
Copy link
Contributor

@shibumi shibumi commented Oct 1, 2018

systemd-resolved supports DNSOverTLS since version 239.
Current Options for this feature are:

  • 'opportunistic'
  • 'no'

There will be a 'strict' or 'yes' feature in the future.

Signed-off-by: Christian Rebischke chris@nullday.de

@shibumi
Copy link
Contributor Author

shibumi commented Oct 1, 2018

Hi this is my second PR. I hope this is enough for implementing another option for systemd-resolved.
@bastelfreak can you have a look over it?

@bastelfreak bastelfreak added the enhancement New feature or request label Oct 1, 2018
@shibumi shibumi force-pushed the shibumi/dns-over-tls branch from 81c2fcf to b1a8bd0 Compare October 1, 2018 20:24
default => $dnsovertls,
}

if $_dnsovertls {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please have a look at the spec/classes/init_spec.rb file add add some spec tests for this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

systemd-resolved supports DNSOverTLS since version 239.
Current Options for this feature are:

*  'opportunistic'
*  'no'

There will be a 'strict' or 'yes' feature in the future.

Signed-off-by: Christian Rebischke <chris@nullday.de>
@shibumi shibumi force-pushed the shibumi/dns-over-tls branch from ff071c7 to 67cce8c Compare October 7, 2018 19:48
@shibumi
Copy link
Contributor Author

shibumi commented Oct 7, 2018

Tests should be implemented now ;)

Copy link
Member

@raphink raphink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bastelfreak bastelfreak changed the title Support for DNSoverTLS Add support for DNSoverTLS Oct 8, 2018
@bastelfreak bastelfreak merged commit 1a8d586 into voxpupuli:master Oct 8, 2018
op-ct pushed a commit to op-ct/puppet-systemd that referenced this pull request Jun 17, 2022
update required Puppet version in the documentation
kajinamit pushed a commit to kajinamit/puppet-systemd that referenced this pull request Mar 25, 2023
Make sysconfig configuration work with undef values for logfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants