Allows % and infinity for Memory Limits + Add MemoryMin #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
reviewed
Mar 16, 2022
|
@SeanHood can you please write some basic tests for this? an example for another type is at https://github.com/voxpupuli/puppet-systemd/blob/master/spec/type_aliases/systemd_coredumpsettings_spec.rb |
Though that type should probably allow some percentages in places as well. Not relevant to this patch. |
Co-authored-by: Romain Tartière <romain@blogreen.org>
|
Thanks for the suggestions, I've pulled in the regex changes and added some basic tests. |
SeanHood
force-pushed
the
memorylimits-can-be-percent
branch
from
2f2c7a3 to
7a14105
Compare
bastelfreak
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The memory service limits were missing support for specifying a percentage of memory, same for
infinity. This PR fixes this.I also noticed that
MemoryMinwas missing.