Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add factory for dropin files #149

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Conversation

TheMeier
Copy link
Contributor

Add a factory for dropin files so they can be simply defined in hiera

@puppet-community-rangefinder
Copy link

systemd is a class

Breaking changes to this file WILL impact these 20 modules (exact match):
Breaking changes to this file MAY impact these 8 modules (near match):

This module is declared in 9 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

manifests/init.pp Outdated Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
@TheMeier
Copy link
Contributor Author

TheMeier commented Jun 3, 2020

I have made the changes with the empty hash default. About dedicated type, isn't that a repitition as the structure of the variables is already set in the definition of the defined resource.

manifests/init.pp Outdated Show resolved Hide resolved
@raphink raphink added the enhancement New feature or request label Jul 15, 2020
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@raphink raphink merged commit 90cc85c into voxpupuli:master Jul 16, 2020
simondeziel pushed a commit to simondeziel/puppet-systemd that referenced this pull request Jun 16, 2021
* add factory for dropin files

* style add colon

Co-authored-by: Christoph Maser <christoph.maser@1und1.de>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
simondeziel pushed a commit to simondeziel/puppet-systemd that referenced this pull request Jun 16, 2021
* add factory for dropin files

* style add colon

Co-authored-by: Christoph Maser <christoph.maser@1und1.de>
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants