Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8 Set selinux context of cache_dir and ports. #89

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

ralfbosz
Copy link
Contributor

When SELINUX is enabled the cache_dir and port are given
the correct SELINUX context (fcontext & port)
Only works on RedHat and families

@ralfbosz
Copy link
Contributor Author

Works only on osfamily == "RedHat".
Didn't include the requirement in metadata.json, since the selinux module isn't supported on Debian and more.

@ekohl
Copy link
Member

ekohl commented Mar 26, 2018

Usually it's good to mention soft dependencies in the README.

When SELINUX is enabled the cache_dir and port are given
the correct SELINUX context (fcontext & port)
Only works on RedHat and families
@traylenator traylenator changed the title This commit addresses issue #8 Fixes #8 Set selinux context of cache_dir and ports. Mar 27, 2018
@traylenator traylenator added the enhancement New feature or request label Mar 27, 2018
@traylenator
Copy link
Contributor

@ralfbosz , thanks. Have been meening to do for a long long time.
I'd say this is a good case for an acceptence test. However happy to merge as is also.

@ralfbosz
Copy link
Contributor Author

Figured out one issue (and confirmed it with a quick test), the fcontext for the cache_dir is set, but not applied (with restorecon). Need to think of a way to trigger that...

@ekohl
Copy link
Member

ekohl commented Mar 27, 2018

@traylenator I recall that SELinux is disabled inside the docker containers we use to test on Travis. It'd be good to know it's not breaking on SELinux disabled, but it wouldn't verify your intended functionality.

@traylenator
Copy link
Contributor

@ekohl Okay - agreed without selinux enabled it is next to pointless.

@traylenator traylenator merged commit 4f86337 into voxpupuli:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants