support forwarded for #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently this would be a breaking change and I'm a bit hesititant to release a major version. Have you thought about compatibility? It also looks like the tests are failing. Could you also have a look at adding one for the new values? |
|
hi @ekohl, |
|
Looks good I'd say and that's nice way of avoiding one the if, elses, I'll steal that for the future. Some tests with the new values would be good.
|
traylenator
added
enhancement
ekohl
reviewed
Sep 27, 2019
added 2 commits
September 27, 2019 13:56
- added some tests - added supported values to readme
|
thanks for your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
right now the param "forward_for" is a boolean that allows to set "on" or "off". Squid however can be configured using one of the values: "on", "off", "transparent", "delete", "truncate".
this PR adds support for this..
also see: http://www.squid-cache.org/Doc/config/forwarded_for/
seems to work for me, please consider to merge it. thanks.