Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for CentOS 6 #870

Merged
merged 1 commit into from
Dec 29, 2020
Merged

Remove support for CentOS 6 #870

merged 1 commit into from
Dec 29, 2020

Conversation

towo
Copy link
Member

@towo towo commented Dec 29, 2020

Pull Request (PR) description

Support for CentOS 6 is removed from metadata.json. There was no stale code to refactor.

CentOS 6 support is making the CI a bad shade of red, and CentOS 6 is EOL, so it should be removed.

Additionally remove a leftover .nodesets.yml.

This Pull Request (PR) fixes the following issues

n/a

@wyardley
Copy link
Contributor

Do you have a link to failed runs? IIRC, Vox hasn’t broadly dropped support though I know there was some discussion of it, and fairly recent PRs have been green IIRC

@towo
Copy link
Member Author

towo commented Dec 29, 2020

@wyardley Sure, #869 has failed CentOS 6 runs where everything else is green. Problem is that the repositories aren't available anymore to pull packages from.

@wyardley wyardley merged commit 5950469 into voxpupuli:master Dec 29, 2020
@wyardley
Copy link
Contributor

@bastelfreak do we flag this as backwards-incompatible?

@wyardley wyardley added the enhancement New feature or request label Dec 29, 2020
@bastelfreak bastelfreak removed the enhancement New feature or request label Dec 29, 2020
@bastelfreak
Copy link
Member

yes. just backwards-incompatible. otherwise it might confuse the changelog generator.

wyardley added a commit to wyardley/puppet-rabbitmq that referenced this pull request Jan 16, 2021
* Add optional variables to support SSL CRL check configuration (voxpupuli#869)
* Remove support for CentOS 6 (voxpupuli#870)
@wyardley wyardley mentioned this pull request Jan 16, 2021
cegeka-jenkins pushed a commit to cegeka/puppet-rabbitmq that referenced this pull request Mar 26, 2021
* Add optional variables to support SSL CRL check configuration (voxpupuli#869)
* Remove support for CentOS 6 (voxpupuli#870)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants