Updates to rabbitmq::server docs #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
force-pushed
the
wyardley-docs-update-2-service
branch
3 times, most recently
from
b0547de
to
4e03fe7
Compare
wyardley
force-pushed
the
wyardley-docs-update-2-service
branch
from
4e03fe7
to
0adc07f
Compare
|
We could also nuke the class. It's been a compat wrapper since 2014. |
|
@ekohl Yeah, my thoughts too. But since I fixed the docs, let’s go ahead and release w/ this, and kill it on the next major (if we remember)? |
ekohl
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Per discussion in #744, document
rabbitmq::server, just because it's so messy.That said, I'm thinking we might want to deprecate / remove this compatibility interface?