Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for ssl verify and 'fail_if_no_peer_cert' for the managem… #657

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Conversation

paebersold
Copy link

…ent ssl options

@wyardley
Copy link
Contributor

@paebersold This is sensibly implemented, thanks for submitting with strings docs, passing tests, etc.
Quick question - are there many other SSL related params? At some point, it would make more sense to have a generic options hash and pas in options that way.
I also find ssl_management_fail_if_no_peer_cert to be really long, not sure if there's a way to make that param shorter but still understandable / consistent...

@wyardley wyardley self-requested a review October 26, 2017 03:21
@wyardley wyardley added the enhancement New feature or request label Oct 26, 2017
@paebersold
Copy link
Author

@wyardley my knowledge of rabbitmq is limited so most of this is based off
https://www.rabbitmq.com/ssl.html and
https://www.rabbitmq.com/configure.html

At the top scope in the config file there are two options missing from the current rabbitmq.config.erb template

  • num_ssl_acceptors
  • ssl_handshake_timeout

From the ssl_options scope missing is

  • honor_ecc_order

Sorry about the long variable name, getting to be more of a short story. For clarity I went for keeping it consistent with the existing variable.

@wyardley
Copy link
Contributor

wyardley commented Oct 27, 2017

Sorry about the long variable name, getting to be more of a short story. For clarity I went for keeping it consistent with the existing variable.

Yes, I think you're right.

@wyardley wyardley merged commit 09e8af2 into voxpupuli:master Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants