Add support for Debian 11 #1010
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
force-pushed
the
wyardley/debian_11
branch
from
a44ba47
to
99ac795
Compare
wyardley
force-pushed
the
wyardley/debian_11
branch
from
99ac795
to
0616766
Compare
Add metadata support for Debian 11, and use the "python3" package for the entire Debian family. This appears to be valid for both currently supported versions Closes voxpupuli#1008
wyardley
force-pushed
the
wyardley/debian_11
branch
from
0616766
to
2fc8dee
Compare
wyardley
commented
Jun 27, 2024
| @@ -190,7 +190,8 @@ | |||
| is_expected.to contain_archive('rabbitmqadmin').with_source('http://1.1.1.1:15672/cli/rabbitmqadmin') | |||
| end | |||
|
|
|||
| it { is_expected.to contain_package('python') } if %w[RedHat Debian SUSE Archlinux].include?(os_facts[:os]['family']) | |||
| it { is_expected.to contain_package('python') } if %w[RedHat SUSE Archlinux].include?(os_facts[:os]['family']) | |||
| it { is_expected.to contain_package('python3') } if %w[Debian].include?(os_facts[:os]['family']) | |||
There was a problem hiding this comment.
I played with single quoting this, but decided to keep the existing style, even for ones where we only have 1 right now.
wyardley
commented
Jun 27, 2024
| @@ -1,4 +1,5 @@ | |||
| --- | |||
| rabbitmq::python_package: 'python3' | |||
There was a problem hiding this comment.
note: these are not alpha sorted; I tried to follow the convention / lack of convention from other files, but happy to reorder some or all of these if necessary.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add metadata support for Debian 11, and use the "python3" package for the entire Debian family. This appears to be valid for both currently supported versions
This Pull Request (PR) fixes the following issues
Closes #1008