modulesync 2.7.0 and drop puppet 4 #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnelson0
reviewed
Apr 19, 2019
| @@ -1,10 +1,23 @@ | |||
| # This file is managed via modulesync | |||
| # https://github.com/voxpupuli/modulesync | |||
| # https://github.com/voxpupuli/modulesync_config | |||
| RSpec.configure do |c| | |||
| c.mock_with :rspec | |||
There was a problem hiding this comment.
Is this why the stub is failing, was this expected to be :mocha? I am not well versed in mocks but seem to recall that being the default previously.
There was a problem hiding this comment.
I did a rewrite of the test based on voxpupuli/puppet-autofs@491d6fc. Unfortunately I do not have write permissions to this repository, so I was forced to create an additional pull request. #484
Convert mocha to rspec-mocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modulesync 2.7.0