Add ability to specify a symlink for r10k.yaml #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allows me to have a symlink for r10k.yaml that points to where the config file is located. This is useful if you want to put the config file in a non-standard location while not having to tell r10k to look in a different place for the config file.
| ```puppet | ||
| include r10k::prerun_command | ||
| ``` | ||
| <pre> |
There was a problem hiding this comment.
Any reason for not using the code fencing here, as even the forge now supports it
There was a problem hiding this comment.
Is there any difference between three backticks and a pre tag?
There was a problem hiding this comment.
code fences support syntax highlighting
https://help.github.com/articles/github-flavored-markdown#syntax-highlighting
|
@ghoneycutt if you can flip the pre's back to GFM code fences then I will get this merged. Thanks for your contribution. |
This patch allows you to parameterize the inclusion of r10k::prerun_command and keep you from having to include a separate class. The code optionally does an include on the class in order to maintain backward compatibility. Recommend that in a future release the code from the prerun_command class is moved into the r10k class where it is currently being included.
|
@acidprime No problem, rebased and squashed to change pre tags to code fences |
acidprime
added a commit
that referenced
this pull request
Jun 2, 2014
Add ability to specify a symlink for r10k.yaml
|
@acidprime thanks for the merge. Could you please tag a release of the code that contains this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows me to have a symlink for r10k.yaml that points to
where the config file is located. This is useful if you want to put the
config file in a non-standard location while not having to tell r10k to
look in a different place for the config file.