Pin webrick gem #401
Merged
Pin webrick gem #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 19, 2017 15:17
Webrick 1.4.1 was released on the 18th of becember 2017. It requires ruby >= 2.3.0. ``` Error: /Stage[main]/R10k::Webhook::Package/Package[webrick]/ensure: change from absent to present failed: Execution of '/opt/puppetlabs/puppet/bin/gem install --no-rdoc --no-ri webrick' returned 1: ERROR: Error installing webrick: webrick requires Ruby version >= 2.3.0 ```
rnelson0
reviewed
Dec 19, 2017
README.md
Outdated
|
|
||
| By default, the `r10k::webhook::package` class uses the `puppet_gem` provider to install the webrick gem (version 1.3.1) | ||
| This version is compatible with all ruby version (webrick version 1.4.1 require Ruby version >=2.3.0) | ||
| If you are overriding `r10k::webhook::package::provider`, you will also need to override `r10k::webhook::package::webrick_version`. |
There was a problem hiding this comment.
may is right.
Should I change it?
There was a problem hiding this comment.
Should we pin webrick to 1.3.1? webrick <= 1.3.1 has some serious security issues (github reminds me daily about it)
There was a problem hiding this comment.
- I think we definitely need the parameter, which this PR brings
- We could then extend the logic to have better defaults per OS if we'd like, still leaving room for overrides
I think # 1 is pretty important as this simply fails right now on new installs, and if we can get #2 in as well, great, but #2 can be addressed by specifying an override.
There was a problem hiding this comment.
I think having the parameter with a default being 1.3.1 should be ok for now. The affected ruby versions in the WEBrick CVE aren't supported by voxpupuli anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webrick 1.4.1 was released on the 18th of becember 2017. It requires ruby >= 2.3.0.
And the provider 'puppet_gem' has only with ruby version 2.2 (Puppet 4)